Clean up FeatureExport.copyFileToDirectory()#2628
Open
rovarga wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR simplifies FeatureExport.copyFileToDirectory() in the features command module by replacing a hand-written stream copy loop with Files.copy(). It is a small cleanup in the feature:export-bundles command path, which exports resolved feature bundles into a target directory.
Changes:
- Replaced manual
FileInputStream/FileOutputStreamcopy logic withFiles.copy(). - Switched destination path construction to
Path.resolve(...)and retained the existing "already exported" behavior when the target file already exists. - Performed minor Javadoc whitespace cleanup alongside the refactor.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| return false; | ||
| } | ||
|
|
||
| Files.copy(file.toPath(), newFile); |
skitt
approved these changes
May 4, 2026
Use Files.copy() instead of open-coding the copy operation. Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use Files.copy() instead of open-coding the copy operation.
Signed-off-by: Robert Varga robert.varga@pantheon.tech